Project

General

Profile

Bug #12731

disable IPv6 LSO until emulation is available

Added by Patrick Mooney 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Patrick Mooney
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
bhyve
Gerrit CR:

Description

Prior to the integration of #12676, we should disable advertisement of IPv6 TSO/LSO. This is because no emulation is available for the MAC loopback path, so if a mac client which doesn't support IPv6 LSO, TSOv6 frames which arrive there would violate its invariants.

Once we have working soft TSOv6, this capability can be advertised to MAC consumers again.

#1

Updated by Patrick Mooney 9 months ago

Ryan built this on top of #12676 (which spurred the need for it) to test and observed TSOv6 as properly disabled on capable hardware:

PASS [test_lso_ip4_primary<i40e0>]
FAIL [test_lso_ip6_primary<i40e0>]: i40e0 sent no packets greater than MTU

#2

Updated by Electric Monk 8 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 97f11506b8e20d03ac8f60ff1b6c7e38a3326df3

commit  97f11506b8e20d03ac8f60ff1b6c7e38a3326df3
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-05-14T17:22:39.000Z

    12731 disable IPv6 LSO until emulation is available
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF