Project

General

Profile

Actions

Bug #12739

closed

gld module missing dep on mac after 12671

Added by Robert Mustacchi over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

12671 swapped most callers from the older hcksum_* routines to mac_hcksum_* routines. While most of the module dependencies were updated, the gld module missed this. This caused the gld module to fail to load, which includes some external drivers such as the vboxnet driver. The fix is to properly declare the dependency in the module Makefiles.

The following is an example of how this fails:

May 15 14:57:48 tesla pseudo: [ID 129642 kern.info] pseudo-device:
vboxusbmon0
May 15 14:57:48 tesla genunix: [ID 936769 kern.info] vboxusbmon0 is
/pseudo/vboxusbmon@0
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/kernel/misc/amd64/gld: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'mac_hcksum_set'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/kernel/misc/amd64/gld: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'mac_hcksum_get'
May 15 14:57:49 tesla genunix: [ID 472681 kern.notice] WARNING:
mod_load: cannot load module 'gld'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_mac_free'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice]  'gld_open'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice]  'gld_rsrv'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice]  'gld_wput'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice]  'gld_wsrv'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_mac_alloc'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_unregister'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_close'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_linkstate'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_register'
May 15 14:57:49 tesla genunix: [ID 819705 kern.notice]
/platform/i86pc/kernel/drv/amd64/vboxnet: undefined symbol
May 15 14:57:49 tesla genunix: [ID 826211 kern.notice] 'gld_getinfo'
May 15 14:57:49 tesla genunix: [ID 472681 kern.notice] WARNING:
mod_load: cannot load module 'vboxnet'
May 15 14:57:49 tesla genunix: [ID 749970 kern.notice] WARNING: vboxnet:
May 15 14:57:49 tesla genunix: [ID 225575 kern.notice] unable to resolve
dependency, module 'misc/gld' not found
May 15 14:57:49 tesla pseudo: [ID 129642 kern.info] pseudo-device: vboxdrv0
May 15 14:57:49 tesla genunix: [ID 936769 kern.info] vboxdrv0 is
/pseudo/vboxdrv@0

Related issues

Related to illumos gate - Feature #12671: hcksum routines are too verboseClosedPatrick Mooney

Actions
Actions #1

Updated by Robert Mustacchi over 1 year ago

Actions #2

Updated by Robert Mustacchi over 1 year ago

This was tested by Aurélien who verified that with the fix in place the vboxnet module correctly loaded.

Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit bd025ac2b6fbfbc59dfc0bd50a0e56dd56de9229

commit  bd025ac2b6fbfbc59dfc0bd50a0e56dd56de9229
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-05-15T19:34:43.000Z

    12739 gld module missing dep on mac after 12671
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Aurélien Larcher  <aurelien.larcher@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF