gcc10 complains about vmcb_state struct packing
As noted in #12746, gcc10 was complaining about pointer access into the
../../i86pc/io/vmm/amd/svm.c: In function 'svm_vmexit': ../../i86pc/io/vmm/amd/svm.c:1522:49: error: taking address of packed member of 'struct vmcb_state' may result in an unaligned pointer value [-Werror=address-of-packed-member] 1522 | handled = x86_emulate_cpuid(svm_sc->vm, vcpu, &state->rax, | ^~~~~~~~~~~ cc1: all warnings being treated as errorsEven with the CPUID issues resolved, it's still not happy about those accesses. Closer inspection of the
vmcb_statestruct calls into question the necessity of its packed status. We can probably remove the
packedattribute, and verify its offsets with
CTASSERT()to safely address the warning.