Project

General

Profile

Actions
Copy link

Bug #12758

closed

ufm_detach doesn't properly clean up

Added by Robert Mustacchi about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
681

Description

While iterating on some ufm related issues, I noticed that the ufm_attach(9E) was failing. The attach routine is very simple. It basically checks the command and whether or not a global dev_info is NULL. Unfortunately ufm_detach never cleans this up. The simple solution is to make sure detach NULLs this out. With this in place I've been able to see attach and detach occur in DTrace on debug bits quite frequently.

Actions
Copy link
 #2

Updated by Joshua M. Clulow about 2 years ago

  • Gerrit CR set to 681
Actions
Copy link
 #3

Updated by Electric Monk about 2 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 8d55b80625b903a8ec6c560f6a38b5c16d1f5cfc

commit  8d55b80625b903a8ec6c560f6a38b5c16d1f5cfc
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-06-12T16:43:33.000Z

    12759 Want ability to read ufm images
    12758 ufm_detach doesn't properly clean up
    12760 igb ufm support
    12765 fwflash plugin cleanup handling is buggy
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Joshua Clulow <josh@sysmgr.org>

Actions
Copy link

Also available in: Atom PDF