Project

General

Profile

Feature #12760

igb ufm support

Added by Robert Mustacchi 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

It'd be nice to enable support for ufm information in igb and allowing us to read the igb eeprom. This change works with #12759 and makes igb the first consumer of the new interfaces. Being able to read the eeprom is also useful for figuring out if folks have hardware the support some of the weirder sensor interfaces as well as general introspection. This will add the ability to both report and read UFM images.


Related issues

Related to illumos gate - Feature #12759: Want ability to read ufm imagesClosedRobert Mustacchi

Actions
Related to illumos gate - Bug #12875: igb I211 doesn't have an nvm version which leads to ufm panicClosedRobert Mustacchi

Actions
#2

Updated by Robert Mustacchi 6 months ago

To test this, in addition to the testing that was a part of 12759, I dumped the eeprom from several different parts including:

  • 82576
  • I350 (both on-board and discrete)

In addition to the fwflash -l output, I went through the dumped eeprom retrieved via fwflash -r and manually verified that different aspects of the flash image all lined up. This included that the mac addresses were there, the VPD section pointers, and more.

#3

Updated by Joshua M. Clulow 6 months ago

  • Gerrit CR set to 681
#4

Updated by Joshua M. Clulow 6 months ago

#5

Updated by Joshua M. Clulow 6 months ago

  • Description updated (diff)
#6

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 8d55b80625b903a8ec6c560f6a38b5c16d1f5cfc

commit  8d55b80625b903a8ec6c560f6a38b5c16d1f5cfc
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-06-12T16:43:33.000Z

    12759 Want ability to read ufm images
    12758 ufm_detach doesn't properly clean up
    12760 igb ufm support
    12765 fwflash plugin cleanup handling is buggy
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Joshua Clulow <josh@sysmgr.org>

#7

Updated by Robert Mustacchi 5 months ago

  • Related to Bug #12875: igb I211 doesn't have an nvm version which leads to ufm panic added

Also available in: Atom PDF