Project

General

Profile

Feature #12761

i40e should only register ufm data on func 0

Added by Robert Mustacchi 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
682

Description

Today, i40e reports a UFM entry on all of its instances. However, the UFM it represents is device wide and in fact it is shared between all ports on the device. Instead we should only report UFM data if this is function zero of the device. Otherwise, this gives the illusion in fwflash and topo that they each of the functions (which should up as different instances) have independent UFMs. However, changing one actually changes them all.

Related issues

Related to illumos gate - Feature #12762: topo should create per-device UFM entries by defaultClosed

Actions

History

#2

Updated by Robert Mustacchi 5 months ago

This was tested (thanks Ryan Zezeski) by looking at the output in fmtopo. Rather than having multiple instances of the firmware information per-function, it now exists on a per-device basis.

#3

Updated by Joshua M. Clulow 5 months ago

  • Related to Feature #12762: topo should create per-device UFM entries by default added
#4

Updated by Joshua M. Clulow 5 months ago

  • Gerrit CR set to 682
#5

Updated by Electric Monk 5 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 44b0ba916e529fad7fa22597911db69ae8f24994

commit  44b0ba916e529fad7fa22597911db69ae8f24994
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-06-12T16:43:33.000Z

    12761 i40e should only register ufm data on func 0
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Approved by: Joshua Clulow <josh@sysmgr.org>

Also available in: Atom PDF