Feature #12762
closed
topo should create per-device UFM entries by default
100%
Description
In the original implementation of the UFM subsystem, UFM entries in topo showed up on a per-PCI function basis by default, but all of the multi-function device at the time (i40e) actually had UFMs shared between all devices. Instead, topo should default to create the UFM data on a per-device basis by default.
I considered adding UFM APIs to indicate this, but until we have devices that actually exist on a per-function basis, it didn't seem like there was much point to doing so. However, if a driver does declare one, then we will go ahead and it to the function when it isn't on function zero so at least it isn't lost.
Related issues
Updated by Robert Mustacchi over 3 years ago
Updated by Robert Mustacchi over 3 years ago
This was tested with fmtopo -V. I verified that we now had ufm entries on the PCI device nodes and not the function level nodes.
Updated by Joshua M. Clulow over 3 years ago
- Related to Feature #12761: i40e should only register ufm data on func 0 added
Updated by Electric Monk over 3 years ago
- Status changed from New to Closed
- % Done changed from 90 to 100
git commit a377495feb6d6c6a51d6cca4065a74f320f29a07
commit a377495feb6d6c6a51d6cca4065a74f320f29a07
Author: Robert Mustacchi <rm@fingolfin.org>
Date: 2020-06-12T16:43:33.000Z
12762 topo should create per-device UFM entries by default
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Approved by: Joshua Clulow <josh@sysmgr.org>