Project

General

Profile

Actions

Bug #12764

open

Holes prevent TRIM

Added by Carsten Endres about 1 year ago. Updated 5 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

90%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Exactly what this ZoL bug states: https://github.com/openzfs/zfs/pull/10227

Added and later removed an SLOG.

Now I can't trim that pool anymore, but get the error message

"cannot remove hole: no such device in pool"

because ZFS apparently stumbles over the removed log device.

ZoL has a solution (linked above); the same could apply to illumos-ZFS.


Files

zfs-test-results.tgz (3.47 MB) zfs-test-results.tgz Carsten Endres, 2021-01-04 09:07 PM
Actions #1

Updated by Carsten Endres about 1 year ago

Bug encountered on OmniOS r34.

Actions #2

Updated by Nick Ewins about 1 year ago

  • Assignee set to Nick Ewins
Actions #3

Updated by Nick Ewins about 1 year ago

Tested to generate the error by creating a zpool and associated SLOG. Removing the SLOG and performing zpool trim <pool> generated the error as expected.

After the modification, further testing was performed. From there, removal of the SLOG and a zpool trim <pool> is completed successfully. The error message is no longer present.

Actions #4

Updated by Nick Ewins about 1 year ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90
Actions #5

Updated by Carsten Endres 12 months ago

Anything I can do to help move this forward? Limited coding experience though...

Actions #6

Updated by Nick Ewins 12 months ago

This patch needs to be tested against the ZFS test suite. I've been looking to get proper hardware. It appears the environment I'm testing against does not see the devices as supporting TRIM. If you would like to run the ZFS test suite, I can certainly help.

Actions #7

Updated by Carsten Endres 5 months ago

Nick Ewins wrote in #note-6:

This patch needs to be tested against the ZFS test suite. I've been looking to get proper hardware. It appears the environment I'm testing against does not see the devices as supporting TRIM. If you would like to run the ZFS test suite, I can certainly help.

(W|L)ife interfered. I have now been able to dig out the result / log files of my ZFS test suite run that you, Nick, kindly walked me through this summer:

https://www.dropbox.com/s/y8cjadh9soh1vyd/zfs-test-results.tgz?dl=0

Actions

Also available in: Atom PDF