Bug #12764
open
Added by Carsten Endres about 2 years ago.
Updated 7 months ago.
Category:
zfs - Zettabyte File System
Description
Exactly what this ZoL bug states: https://github.com/openzfs/zfs/pull/10227
Added and later removed an SLOG.
Now I can't trim that pool anymore, but get the error message
"cannot remove hole: no such device in pool"
because ZFS apparently stumbles over the removed log device.
ZoL has a solution (linked above); the same could apply to illumos-ZFS.
Files
Bug encountered on OmniOS r34.
- Assignee set to Nick Ewins
Tested to generate the error by creating a zpool and associated SLOG. Removing the SLOG and performing zpool trim <pool> generated the error as expected.
After the modification, further testing was performed. From there, removal of the SLOG and a zpool trim <pool> is completed successfully. The error message is no longer present.
- Status changed from New to In Progress
- % Done changed from 0 to 90
Anything I can do to help move this forward? Limited coding experience though...
This patch needs to be tested against the ZFS test suite. I've been looking to get proper hardware. It appears the environment I'm testing against does not see the devices as supporting TRIM. If you would like to run the ZFS test suite, I can certainly help.
Nick Ewins wrote in #note-6:
This patch needs to be tested against the ZFS test suite. I've been looking to get proper hardware. It appears the environment I'm testing against does not see the devices as supporting TRIM. If you would like to run the ZFS test suite, I can certainly help.
(W|L)ife interfered. I have now been able to dig out the result / log files of my ZFS test suite run that you, Nick, kindly walked me through this summer:
https://www.dropbox.com/s/y8cjadh9soh1vyd/zfs-test-results.tgz?dl=0
Bug is still present in release-20210701.
Also available in: Atom
PDF