Project

General

Profile

Bug #12770

stop including exception unwind info in the kernel

Added by Rich Lowe 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Low
Assignee:
Rich Lowe
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
687

Description

It's a minor thing, but we should stop including .eh_frame in kernel objects. Nothing should be throwing exceptions or unwinding in there.

#1

Updated by Rich Lowe 5 months ago

  • Gerrit CR set to 687
#2

Updated by Rich Lowe 5 months ago

I talked to some people I know have thought about using languages that
in theory support unwinding exceptions in the kernel, they unanimously
wanted such things to panic rather than be caught. We agreed should
they ever change their mind, this would be easy enough to restore (and
that they'd likely have to write runtime code to map/use it the info).

It was mentioned to me in private mail (for reasons unrelated to this
change) that SunCluster/OHAC contains C++ kernel code. I have not been
able to find a copy of the code to check whether it throws/catches
through other code, or indeed at all. The point of the mail that
brought this up was also that it does not work (anyway) at the moment,
so I haven't investigated further than making an attempt to find the old
open code.

I tested with build and boot

#3

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 9b9e3196fde9c0f47c8cc4ab00f3bc5b539ceaca

commit  9b9e3196fde9c0f47c8cc4ab00f3bc5b539ceaca
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2020-06-26T16:56:45.000Z

    12770 stop including exception unwind info in the kernel
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF