Project

General

Profile

Actions
Copy link

Feature #12791

closed

rpcgen: if main is not provided, _svcstate_lock should be extern

Added by Toomas Soome about 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
703

Description

When we do generate svc stubs without main, we should declare "mutex_t _svcstate_lock" as "extern", so we can decide where we are going to instatiate it. This lock is used for internal housekpeeing, the name is fixed and will get on the way in case when we implement multiple RPC programs in the same application.

This change does also reveal issues with some of the applications:

fmd: missing mutex_init()
gssd: missing mutex_init()
kwarn: missing mutex_init()
idmapd: needs _svcstate_lock to be added

Testing done: build/install/boot, RPC related programs behave as expected.

Related issues

Related to illumos gate - Feature #12787: build needs native rpcgenClosedToomas Soome

Actions
Actions
Copy link
 #1

Updated by Toomas Soome about 2 years ago

Actions
Copy link
 #2

Updated by Toomas Soome about 2 years ago

  • Gerrit CR set to 703
Actions
Copy link
 #3

Updated by Toomas Soome 10 months ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 60414d478553487f99278a4302d1116e73d5f6dc

commit  60414d478553487f99278a4302d1116e73d5f6dc
Author: Toomas Soome <tsoome@me.com>
Date:   2021-09-14T06:47:45.000Z

    12791 rpcgen: if main is not provided, _svcstate_lock should be extern
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF