Project

General

Profile

Bug #12799

mlxcx #if defined for MAC_VLAN_UNTAGGED is redundant

Added by Paul Winder 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

There were some #if defined statements for MAC_VLAN_UNTAGGED, from when the code was originally developed, they are now redundant and can be removed.


Related issues

Related to illumos gate - Bug #12797: mlxcx max flow table limit can be exceededClosedPaul Winder

Actions
Related to illumos gate - Bug #12798: mlxcx command interface should allow concurrent commands and be interrupt drivenClosedPaul Winder

Actions
Related to illumos gate - Bug #12890: mlxcx uses excessive stack space causing stack overflow panicClosedPaul Winder

Actions
#1

Updated by Paul Winder 5 months ago

  • Gerrit CR set to 705
#2

Updated by Paul Winder 5 months ago

  • Status changed from New to In Progress
#3

Updated by Dan McDonald 4 months ago

  • Related to Bug #12797: mlxcx max flow table limit can be exceeded added
#4

Updated by Dan McDonald 4 months ago

  • Related to Bug #12798: mlxcx command interface should allow concurrent commands and be interrupt driven added
#5

Updated by Dan McDonald 4 months ago

  • Related to Bug #12890: mlxcx uses excessive stack space causing stack overflow panic added
#6

Updated by Paul Winder 4 months ago

See #12798 for testing info

#7

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

git commit 5f0e3176f407dfb9d989b5dcc94a6d5384d0b142

commit  5f0e3176f407dfb9d989b5dcc94a6d5384d0b142
Author: Paul Winder <pwinder@racktopsystems.com>
Date:   2020-07-10T15:41:30.000Z

    12797 mlxcx max flow table limit can be exceeded
    12798 mlxcx command interface should allow concurrent commands and be interrupt driven
    12799 mlxcx #if defined for MAC_VLAN_UNTAGGED is redundant
    12890 mlxcx uses excessive stack space causing stack overflow panic
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Alex Wilson <alex@cooperi.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF