Project

General

Profile

Actions
Copy link

Bug #12803

closed

unix: duplicate symbols in the kernel

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
709

Description

When built with gcc 10, krtld will report duplicate symbols swapinfo and v, and indeed:

swapinfo is defined in uts/common/vm/vm_swap.c and in uts/vcommon/conf/param.c

This patch does change instance in vm_swap to extern. Duplicate swapinfo does cause kernel panic on boot (due to unexpected values in structure).

struct var v is defined in uts/common/os/space.c and in uts/vcommon/conf/param.c

This patch does remove instance from space.c.

Testing done: build/install/boot (gcc10 and 7).

Actions
Copy link
 #1

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
  • Gerrit CR set to 709
Actions
Copy link
 #2

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6cdd461fe55315d9bc0ba40ea7da22cddbdcf784

commit  6cdd461fe55315d9bc0ba40ea7da22cddbdcf784
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-11T06:31:51.000Z

    12803 unix: duplicate symbols in the kernel
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF