Project

General

Profile

Actions

Bug #12804

closed

sysevent.h: C++11 requires a space between string literal and macro

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 10:

In file included from /code/illumos-gate/proto/root_i386/usr/include/sys/sunddi.h:54,
                 from /code/illumos-gate/proto/root_i386/usr/include/libdevinfo.h:35,
                 from ../common/HBAPort.cc:42:
/code/illumos-gate/proto/root_i386/usr/include/sys/sysevent.h:76:40: error: C++11 requires a space between str
ing literal and macro [-Werror=c++11-compat]
   76 | #define ILLUMOS_KERN_PUB ILLUMOS_VENDOR":"SE_KERN_PUB
      |                                        ^
cc1plus: all warnings being treated as errors
*** Error code 1
dmake: Warning: Command failed for target `pics/HBAPort.o'
Current working directory /code/illumos-gate/usr/src/lib/sun_fc/i386

Testing done: build/install/boot.

Actions #1

Updated by Toomas Soome almost 2 years ago

  • Gerrit CR set to 710
Actions #2

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit fdf1a8710a94b4953ba782ed5bdc1549b0356ddc

commit  fdf1a8710a94b4953ba782ed5bdc1549b0356ddc
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-01T22:17:32.000Z

    12804 sysevent.h: C++11 requires a space between string literal and macro
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF