Project

General

Profile

Actions
Copy link

Bug #12808

closed

sun4u/unix: this 'if' clause does not guard

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
712

Description

Build error on SPARC:

    ../../sun4/os/cpu_states.c: In function 'abort_sequence_enter':
    ../../sun4/os/cpu_states.c:188:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
       if (!on_intr && auditing)
       ^~
    ../../sun4/os/cpu_states.c:190:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
        (*abort_seq_handler)(msg);
        ^
    cc1: all warnings being treated as errors

Testing done: I have this fix part of tree I use to build gate on SPARC, the build is used to run the ldom on T4-1, which is my build host.

Actions
Copy link
 #1

Updated by Toomas Soome almost 2 years ago

  • Gerrit CR set to 712
Actions
Copy link
 #2

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 2a93e0bc6b60286283274376cae765bed0c59594

commit  2a93e0bc6b60286283274376cae765bed0c59594
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-31T17:55:13.000Z

    12808 sun4u/unix: this 'if' clause does not guard
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF