Project

General

Profile

Bug #12815

ucode/update.intel needs pkgfmt fix

Added by Dan McDonald 2 months ago. Updated about 2 months ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
system data
Start date:
Due date:
% Done:

90%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The invocation of pkgfmt in update.intel doesn't set the version like the rest of -gate does. This causes large & unnecessary diffs.

diff --git a/usr/src/data/ucode/update.intel b/usr/src/data/ucode/update.intel
index 52ed8c0eb7..eaa71539a6 100755
--- a/usr/src/data/ucode/update.intel
+++ b/usr/src/data/ucode/update.intel
@@ -19,6 +19,9 @@
 set -e
 set -o pipefail

+# Remove this once we start using pkgfmt without it in the rest of -gate.
+export PKGFMT_OUTPUT=v1
+
 [[ -z "$1" ]] || [[ ! -f "$1" ]] && {
        echo "Syntax: $0 <path to microcode tar>" >&2
        exit 1

should do the trick.


Related issues

Related to illumos gate - Feature #12816: Update Intel microcode to 20200616Closed

Actions
Related to illumos gate - Bug #12817: ucode/update.intel should be able to use git reposIn Progress

Actions
Related to illumos gate - Bug #12828: ucode/update.intel should be able to use git reposDuplicate

Actions

History

#1

Updated by Dan McDonald 2 months ago

#2

Updated by Dan McDonald 2 months ago

Tested during the update for #12816. Pre-fix, generated terrible noise in the manifest. Post-fix, no noise at all.

#3

Updated by Dan McDonald 2 months ago

  • Related to Bug #12817: ucode/update.intel should be able to use git repos added
#4

Updated by Yuri Pankov 2 months ago

Dan McDonald wrote:

Tested during the update for #12816. Pre-fix, generated terrible noise in the manifest. Post-fix, no noise at all.

It should actually fail during the packaging step, wonder why it doesn't for you.

#5

Updated by Dan McDonald 2 months ago

Yuri Pankov wrote:

It should actually fail during the packaging step, wonder why it doesn't for you.

I noticed prior to running nightly. The sheer volume of diffs were the indicator of a problem.

#6

Updated by Andy Fiddaman 2 months ago

I have always run update.intel inside a `bldenv`, which is why I haven't seen this.
It doesn't hurt to set the variable explicitly though.

#7

Updated by Dan McDonald 2 months ago

  • Related to Bug #12828: ucode/update.intel should be able to use git repos added
#8

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 16b19c8cd6c6339e907197a5a8c30bdb85ec0ef8

commit  16b19c8cd6c6339e907197a5a8c30bdb85ec0ef8
Author: Dan McDonald <danmcd@joyent.com>
Date:   2020-06-08T23:59:09.000Z

    12815 ucode/update.intel needs pkgfmt fix

#9

Updated by Dan McDonald 2 months ago

  • Status changed from Closed to In Progress
  • % Done changed from 100 to 90
#10

Updated by Electric Monk 2 months ago

git commit eb7a235af24981be82a88a125b4f82093a408ef4

commit  eb7a235af24981be82a88a125b4f82093a408ef4
Author: Dan McDonald <danmcd@joyent.com>
Date:   2020-06-09T14:47:10.000Z

    Revert "12817 ucode/update.intel should be able to use git repos" 
    This reverts commit d9660a7c6537b3e744aca576d92fcef0d6efcea2.
    Revert "12815 ucode/update.intel needs pkgfmt fix" 
    This reverts commit 16b19c8cd6c6339e907197a5a8c30bdb85ec0ef8.

#11

Updated by Dan McDonald about 2 months ago

Testing done: Generated patch for #12816 using this and #12817's fixes.

Also available in: Atom PDF