Project

General

Profile

Actions
Copy link

Feature #12832

closed

topo support for generic PCI device temp sensors

Added by Robert Mustacchi about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
724

Description

With making it easier to create sensors on a per-device basis with the ksensor framework, we should make it easy to create sensors that show up in topo for PCI devices that have sensors. The neat benefit here is that by calling ksensor_create_temp_pcidev() things automatically show up in topo without any additional per-topo work.

Related issues

Related to illumos gate - Feature #12830: Want centralized ksensor frameworkClosedRobert Mustacchi

Actions
Actions
Copy link
 #1

Updated by Robert Mustacchi about 2 years ago

Actions
Copy link
 #2

Updated by Robert Mustacchi about 2 years ago

  • Gerrit CR set to 724
Actions
Copy link
 #3

Updated by Robert Mustacchi almost 2 years ago

This was tested in conjunction with #12835. In that change igb(7D) leverages the facilities here which causes the node to show up in /dev/sensors and in fmtopo automatically. See #12835 for more detailed examples. (Fixed bugID typo)

Actions
Copy link
 #4

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 3ce5372277f4657ad0e52d36c979527c4ca22de2

commit  3ce5372277f4657ad0e52d36c979527c4ca22de2
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-07-12T14:24:19.000Z

    12830 Want centralized ksensor framework
    12831 temperature sensors could describe accuracy
    12832 topo support for generic PCI device temp sensors
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Reviewed by: Toomas Soome <toomas@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF