Project

General

Profile

Actions

Feature #12833

closed

Rewrite pchtemp to use the ksensor framework

Added by Robert Mustacchi over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

With the addition of the new sensor framework, we should use this and simplify the implementation of pchtemp(7D). This simplifies the driver and adds a nice reduction in line count and more.

Actions #1

Updated by Robert Mustacchi over 1 year ago

  • Gerrit CR set to 725
Actions #2

Updated by Robert Mustacchi over 1 year ago

I tested this by passing through an instance of pchtemp to a VM that had the Cannon Point-LP device (pci8086,9df9) and tested that the updated driver worked and showed up in topo.

rm@nienor:~$ pfexec /usr/lib/fm/fmd/fmtopo -V *sensor*
TIME                 UUID
Jul 06 20:37:20 34431d0a-9f37-e244-f52a-ba8f26f458fe

hc://:product-id=Standard-PC-(i440FX-+-PIIX,-1996):server-id=nienor/motherboard=0/chipset=0?sensor=temp
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:product-id=Standard-PC-(i440FX-+-PIIX,-1996):server-id=nienor/motherboard=0/chipset=0?sensor=temp
  group: authority                      version: 1   stability: Private/Private
    product-id        string    Standard-PC-(i440FX-+-PIIX,-1996)
    server-id         string    nienor
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    46.000000
Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 026742805847ca4c0c7ca8af50d2ba6a1f4b2b90

commit  026742805847ca4c0c7ca8af50d2ba6a1f4b2b90
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-07-12T14:24:19.000Z

    12833 Rewrite pchtemp to use the ksensor framework
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Reviewed by: Toomas Soome <toomas@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF