Project

General

Profile

Feature #12835

Want support for I350 temperature sensor

Added by Robert Mustacchi about 2 months ago. Updated 25 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
727

Description

The Intel I350 which is supported by the igb driver has a built-in thermal diode and optional support for an external temperature sensor indicated in its eeprom. This change adds support for the built-in thermal diode as I have not been able to find a discrete I350 with these features enabled in its EEPROM yet. Though extending it in such a case would be useful. This leverages the framework introduced in 12830.

Related issues

Related to illumos gate - Feature #12830: Want centralized ksensor frameworkClosed

Actions

History

#1

Updated by Robert Mustacchi about 2 months ago

#2

Updated by Robert Mustacchi about 2 months ago

  • Gerrit CR set to 727
#3

Updated by Robert Mustacchi about 1 month ago

To test this I ran these bits on a system that had the I350 and verified that it showed up in fmtopo. Here's an example of it showing up on a system with a single built-in I350:

rm@beowulf:~$ find /dev/sensors/
/dev/sensors/
/dev/sensors/temperature
/dev/sensors/temperature/cpu
/dev/sensors/temperature/cpu/procnode.0
/dev/sensors/temperature/pci
/dev/sensors/temperature/pci/41.0
/dev/sensors/temperature/pci/41.0/builtin
rm@beowulf:~$ pfexec /usr/lib/fm/fmd/fmtopo -V *sensor*
...
hc://:server-id=beowulf/motherboard=0/hostbridge=3/pciexrc=3/pciexbus=65/pciexdev=0?sensor=builtin
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf/motherboard=0/hostbridge=3/pciexrc=3/pciexbus=65/pciexdev=0?sensor=builtin
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: facility                       version: 1   stability: Private/Private
    sensor-class      string    threshold
    type              uint32    0x1 (TEMP)
    units             uint32    0x1 (DEGREES_C)
    reading           double    47.000000

In addition, Ryan Zezeski also tested this on a discrete I350 he had and verified that things showed up in topo.

#4

Updated by Electric Monk 25 days ago

  • Status changed from New to Closed
  • % Done changed from 80 to 100

git commit 2509632a43b285708c172d4221818e8b79cea126

commit  2509632a43b285708c172d4221818e8b79cea126
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-07-12T14:24:19.000Z

    12835 Want support for I350 temperature sensor
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Reviewed by: Toomas Soome <toomas@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF