Project

General

Profile

Actions
Copy link

Bug #12836

closed

loader: strings in nvlist are counted strings, not c-strings

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
721

Description

The nvlist stream format has string data defined as <size><bytes..>, it may be padded by zeros to align by 4. This means, we can not use C string functions to handle string data from nvlist. To handle this, we need to get string length from nvlist_find() and use it to handle the data.

Testing done: build/install/boot

Actions
Copy link
 #1

Updated by Toomas Soome about 2 years ago

  • Description updated (diff)
  • Gerrit CR set to 721
Actions
Copy link
 #2

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit ce5f7fb896fce369b4ec50da6d3a232bce2458ce

commit  ce5f7fb896fce369b4ec50da6d3a232bce2458ce
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-19T17:39:31.000Z

    12836 loader: strings in nvlist are counted strings, not c-strings
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF