Project

General

Profile

Actions

Bug #12873

closed

pci_autoconf: Makefile and compiler warning cleanup

Added by Andy Fiddaman about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The Makefile for the Intel pci_autoconfig module suppresses a few compiler warnings. These turn out to be easy to fix and, once done, that exposes a bug in one of the macros used for identifying a particular

usr/src/uts/i86pc/sys/pci_cfgacc_x86.h

#define    IS_AMD_8132_CHIP(vid, did) \
        (((vid) == AMD_NTBRDIGE_VID) && \
        (((did) == AMD_8132_BRIDGE_DID)) || \
        (((did) == AMD_8132_IOAPIC_DID)))

should be

#define    IS_AMD_8132_CHIP(vid, did) \
        (((vid) == AMD_NTBRDIGE_VID) && \
        (((did) == AMD_8132_BRIDGE_DID) || \
        ((did) == AMD_8132_IOAPIC_DID)))

Actions #1

Updated by Electric Monk about 2 years ago

  • Gerrit CR set to 732
Actions #2

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 6ecc470585ed07369dd51b0ed85f5cf848e5b5c2

commit  6ecc470585ed07369dd51b0ed85f5cf848e5b5c2
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-07-02T14:48:34.000Z

    12867 Mis-programmed pcie bridge leaves 64-bit device unusable
    12873 pci_autoconf: Makefile and compiler warning cleanup
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Paul Winder <paul@winder.uk.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF