Project

General

Profile

Bug #12891

eri: this 'if' clause does not guard...

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error on SPARC:

    ../../sun/io/eri/eri.c: In function 'eri_check_txhung':
    ../../sun/io/eri/eri.c:5523:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
      if (erip->flags & ERI_RUNNING)
      ^~
    ../../sun/io/eri/eri.c:5526:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
       macupdate |= eri_reclaim(erip, erip->tx_completion);
       ^~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

#1

Updated by Toomas Soome 5 months ago

  • Gerrit CR set to 749
#2

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 7e9964352166d31ee78f8ed0e600c9e32d9d72a4

commit  7e9964352166d31ee78f8ed0e600c9e32d9d72a4
Author: Toomas Soome <tsoome@me.com>
Date:   2020-07-09T18:08:24.000Z

    12891 eri: this 'if' clause does not guard...
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF