Project

General

Profile

Bug #12921

bhyve IPI statistics should not be a matrix

Added by Patrick Mooney about 1 month ago. Updated 29 days ago.

Status:
Closed
Priority:
Low
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
bhyve
Gerrit CR:

Description

The statistics facility in bhyve currently stores counts of IPIs sent per-vcpu in a VM_MAXCPUs-sized array. While this matrix of who-sent-who-IPIs is detailed, those running counts over the lifetime of the VM seem questionable when compared to the complexity it introduces with respect to making the max vCPU count for a VM more dynamic. It should be fine to simplify this to a count of IPIs send/received per vCPU.

History

#1

Updated by Patrick Mooney about 1 month ago

Prior to the change, querying statistics with bhyvectl would show VM_MAXCPU count of IPI statistics per-vcpu:

ipis sent to vcpu[0]                            0
ipis sent to vcpu[1]                            0
ipis sent to vcpu[2]                            0
ipis sent to vcpu[3]                            0
ipis sent to vcpu[4]                            0
ipis sent to vcpu[5]                            0
ipis sent to vcpu[6]                            0
ipis sent to vcpu[7]                            0
ipis sent to vcpu[8]                            0
ipis sent to vcpu[9]                            0
ipis sent to vcpu[10]                           0
ipis sent to vcpu[11]                           0
ipis sent to vcpu[12]                           0
ipis sent to vcpu[13]                           0
ipis sent to vcpu[14]                           0
ipis sent to vcpu[15]                           0
ipis sent to vcpu[16]                           0
ipis sent to vcpu[17]                           0
ipis sent to vcpu[18]                           0
ipis sent to vcpu[19]                           0
ipis sent to vcpu[20]                           0
ipis sent to vcpu[21]                           0
ipis sent to vcpu[22]                           0
ipis sent to vcpu[23]                           0
ipis sent to vcpu[24]                           0
ipis sent to vcpu[25]                           0
ipis sent to vcpu[26]                           0
ipis sent to vcpu[27]                           0
ipis sent to vcpu[28]                           0
ipis sent to vcpu[29]                           0
ipis sent to vcpu[30]                           0
ipis sent to vcpu[31]                           0

#2

Updated by Patrick Mooney about 1 month ago

With the patch, the summarized stats are available:

ipis sent from vcpu                             3810
ipis received by vcpu                           7735

#3

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 769
#4

Updated by Electric Monk 29 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 65a3bc83734e5fb0fc2c19df3e5112b87dcdc3f8

commit  65a3bc83734e5fb0fc2c19df3e5112b87dcdc3f8
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-07-10T18:41:55.000Z

    12921 bhyve IPI statistics should not be a matrix
    Reviewed by: Jason King <jason.king@joyent.com>
    Reviewed by: Mike Zeller <mike.zeller@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF