Bug #12922
closed
bhyve vmm ops could have stronger guardrail
Added by Patrick Mooney almost 2 years ago.
Updated almost 2 years ago.
Description
When bhyve is initialized, it chooses a vmm_ops set, based on the physical CPU (Intel or AMD) it's running on. The macros which call into this struct have explicit checks for it being non-NULL, which should never be possible given our guards anyways. To simplify those macros and maintain the safety, we could populate a null-ish vmm_ops struct with functions that simply panic.
This is just a minor clean-up, and considering it's already a well-protected error case, should not be at all visible to a system.
I've tested this on AMD and Intel systems to confirm that bhyve loads properly and is able to start VMs without issue.
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit b38fc3ed80ecaf16c46433e690e6f17495c5e179
commit b38fc3ed80ecaf16c46433e690e6f17495c5e179
Author: Patrick Mooney <pmooney@pfmooney.com>
Date: 2020-07-13T17:20:06.000Z
12922 bhyve vmm ops could have stronger guardrail
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Mike Zeller <mike.zeller@joyent.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Also available in: Atom
PDF
Updated by 
Updated by