Project

General

Profile

Actions

Bug #12923

closed

SMT exclusion should not balk at GZ

Added by Patrick Mooney over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The SMT exclusion, used to mitigate some micro-architectural leakage between threads on a single core, currently ASSERT()-s that the caller is not running in the global zone. This prevents bhyve (which obeys the exclusion) from running in the GZ, at least in kernels build with DEBUG. This restriction is somewhat onerous for folks who want to run bhyve outside of a zone. (The easiest way to do so on vanilla illumos-gate right now)


Related issues

Related to illumos gate - Bug #12945: SMT exclusion should be by pid rather than zoneidNew

Actions
Actions #1

Updated by Patrick Mooney over 2 years ago

With the proposed patch, I was able to start a bhyve instance in the global zone on a DEBUG platform without an immediate ASSERT panic. The VM came up fine and was functional.

Actions #2

Updated by Electric Monk over 2 years ago

  • Gerrit CR set to 770
Actions #3

Updated by Patrick Mooney over 2 years ago

Mike Zeller confirmed that a mix of bhyve instances (both in the GZ and in NGZs) ran fine on a DEBUG kernel featuring this change.

Actions #4

Updated by Patrick Mooney over 2 years ago

  • Related to Bug #12945: SMT exclusion should be by pid rather than zoneid added
Actions #5

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit fe354f7669cae68869feea028566f75f357ae5e7

commit  fe354f7669cae68869feea028566f75f357ae5e7
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-07-10T18:06:27.000Z

    12923 SMT exclusion should not balk at GZ
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Mike Zeller <mike.zeller@joyent.com>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

Actions

Also available in: Atom PDF