Project

General

Profile

Bug #12947

stand: this statement may fall through

Added by Toomas Soome 27 days ago. Updated 17 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors on sparc:

    ipv4.c: In function 'ipv4_route':
    ipv4.c:382:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (cmd == IPV4_DEL_ROUTE) {
          ^
    ipv4.c:388:2: note: here
      default:
      ^~~~~~~

    socket.c: In function 'getsockopt':
    socket.c:238:7: error: this statement may fall through [-Werror=implicit-fallthr
    ough=]
        if (*optlen == sizeof (struct linger)) {
           ^
    socket.c:245:3: note: here
       default:
       ^~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install.. set up network boot and the inetboot program still seems to work...

History

#1

Updated by Electric Monk 27 days ago

  • Gerrit CR set to 790
#2

Updated by Toomas Soome 17 days ago

  • Description updated (diff)
#3

Updated by Electric Monk 17 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a963a5aa3ca3777616e2475ae05969f48439c694

commit  a963a5aa3ca3777616e2475ae05969f48439c694
Author: Toomas Soome <tsoome@me.com>
Date:   2020-07-21T19:26:05.000Z

    12947 stand: this statement may fall through
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF