Project

General

Profile

Bug #12948

dr_cpu: this statement may fall through

Added by Toomas Soome 28 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors on SPARC:

    ../../sun4v/io/dr_cpu.c: In function 'dr_cpu_list_wrk':
    ../../sun4v/io/dr_cpu.c:413:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
       force = B_TRUE;
       ~~~~~~^~~~~~~~
    ../../sun4v/io/dr_cpu.c:415:2: note: here
      case DR_CPU_UNCONFIGURE:
      ^~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

History

#1

Updated by Electric Monk 28 days ago

  • Gerrit CR set to 791
#2

Updated by Toomas Soome 18 days ago

  • Description updated (diff)
#3

Updated by Electric Monk 18 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit acdc433c352771bfb6a3cf85e6bc74782da919af

commit  acdc433c352771bfb6a3cf85e6bc74782da919af
Author: Toomas Soome <tsoome@me.com>
Date:   2020-07-21T17:53:09.000Z

    12948 dr_cpu: this statement may fall through
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF