Actions
Bug #12949
closeddrctl: this statement may fall through
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
Description
Build errors on SPARC:
In file included from ../../sun4v/io/drctl_impl.c:34:0: ../../sun4v/io/drctl_impl.c: In function 'i_drctl_send': ../../sun4v/sys/dr_util.h:70:40: error: this statement may fall through [-Werror=implicit-fallthrough=] #define DR_DBG_ALL _NOTE(CONSTCOND) if (0) printf ^ ../../sun4v/sys/dr_util.h:71:20: note: in expansion of macro 'DR_DBG_ALL' #define DR_DBG_CTL DR_DBG_ALL ^~~~~~~~~~ ../../sun4v/io/drctl_impl.c:126:4: note: in expansion of macro 'DR_DBG_CTL' DR_DBG_CTL("%s: door call returned EINTR\n", me); ^~~~~~~~~~ ../../sun4v/io/drctl_impl.c:128:3: note: here case EAGAIN: ^~~~ cc1: all warnings being treated as errors
Testing done: build/install/boot
Updated by Electric Monk almost 2 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 88b620a7b440907cc75f1955c584204c6b79b6fd
commit 88b620a7b440907cc75f1955c584204c6b79b6fd Author: Toomas Soome <tsoome@me.com> Date: 2020-07-21T13:54:40.000Z 12949 drctl: this statement may fall through Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Peter Tribble <peter.tribble@gmail.com> Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net> Approved by: Dan McDonald <danmcd@joyent.com>
Actions