Project

General

Profile

Actions

Bug #12949

closed

drctl: this statement may fall through

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors on SPARC:

    In file included from ../../sun4v/io/drctl_impl.c:34:0:
    ../../sun4v/io/drctl_impl.c: In function 'i_drctl_send':
    ../../sun4v/sys/dr_util.h:70:40: error: this statement may fall through [-Werror=implicit-fallthrough=]
     #define DR_DBG_ALL _NOTE(CONSTCOND) if (0) printf
                                            ^
    ../../sun4v/sys/dr_util.h:71:20: note: in expansion of macro 'DR_DBG_ALL'
     #define DR_DBG_CTL DR_DBG_ALL
                        ^~~~~~~~~~
    ../../sun4v/io/drctl_impl.c:126:4: note: in expansion of macro 'DR_DBG_CTL'
        DR_DBG_CTL("%s: door call returned EINTR\n", me);
        ^~~~~~~~~~
    ../../sun4v/io/drctl_impl.c:128:3: note: here
       case EAGAIN:
       ^~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

Actions

Also available in: Atom PDF