Project

General

Profile

Bug #12950

pcicmu: this statement may fall through

Added by Toomas Soome 28 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors on SPARC:

    ../../../sun4u/opl/io/oplmsu/oplmsu_ioctl_uwp.c: In function 'oplmsu_uwioctl_ipunlink':
    ../../../sun4u/opl/io/oplmsu/oplmsu_ioctl_uwp.c:212:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
        if (upath->traditional_status == MSU_SETID) {
           ^
    ../../../sun4u/opl/io/oplmsu/oplmsu_ioctl_uwp.c:225:3: note: here
       default :
       ^~~~~~~

    ../../../sun4u/opl/io/pcicmu/pcmu_util.c: In function 'pcmu_cfg_report':
    ../../../sun4u/opl/io/pcicmu/pcmu_util.c:510:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
         aux_msg = "Recieved Master Abort";
         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
    ../../../sun4u/opl/io/pcicmu/pcmu_util.c:512:4: note: here
        case PCI_STAT_R_TARG_AB:
        ^~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

History

#1

Updated by Electric Monk 28 days ago

  • Gerrit CR set to 793
#2

Updated by Toomas Soome 18 days ago

  • Description updated (diff)
#3

Updated by Electric Monk 18 days ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9b65801e8bd9a9007efed89ac479e99b9dab83d1

commit  9b65801e8bd9a9007efed89ac479e99b9dab83d1
Author: Toomas Soome <tsoome@me.com>
Date:   2020-07-21T17:33:11.000Z

    12950 pcicmu: this statement may fall through
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF