Project

General

Profile

Actions
Copy link

Bug #12952

closed

ms: this statement may fall through

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
795

Description

Build errors on SPARC:

    ../../sun/io/ms.c: In function 'msrput':
    ../../sun/io/ms.c:925:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (*mp->b_rptr & FLUSHR)
          ^
    ../../sun/io/ms.c:928:2: note: here
      default:
      ^~~~~~~
    ../../sun/io/ms.c: In function 'mswput':
    ../../sun/io/ms.c:707:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
       if (*mp->b_rptr & FLUSHR)
          ^
    ../../sun/io/ms.c:710:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

Actions
Copy link
 #1

Updated by Electric Monk almost 2 years ago

  • Gerrit CR set to 795
Actions
Copy link
 #2

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 6937e379563aa5fe8a003acdcd316b89044dd8dd

commit  6937e379563aa5fe8a003acdcd316b89044dd8dd
Author: Toomas Soome <tsoome@me.com>
Date:   2020-07-22T19:05:35.000Z

    12952 ms: this statement may fall through
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF