Project

General

Profile

Actions

Feature #12954

closed

Rewrite coretemp to use the ksensor framework

Added by Robert Mustacchi 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

With the ksensor framework that was introduced in #12830, we should rewrite coretemp(7D) to take advantage of this as well and simplify it.


Related issues

Related to illumos gate - Bug #12955: coretemp had the wrong granularityClosedRobert Mustacchi

Actions
Related to illumos gate - Feature #11184: Want CPU Temperature SensorsClosedRobert Mustacchi

Actions
Actions #1

Updated by Electric Monk 10 months ago

  • Gerrit CR set to 797
Actions #2

Updated by Robert Mustacchi 10 months ago

  • Related to Bug #12955: coretemp had the wrong granularity added
Actions #3

Updated by Robert Mustacchi 10 months ago

Actions #4

Updated by Robert Mustacchi 9 months ago

This was tested by others for me. Each them ran fmtop -V and verified that we had the appropriate temperature sensors still. In particular, we verified this on a couple different classes of Intel systems, notably both those with the package level sensor (added in approximately Ivy Bridge) and those without. In both cases, we verified that the per-core sensors were still present and valid.

Actions #5

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 01c0c40b21ae5d91e9c44377d6b19c9326e8e94f

commit  01c0c40b21ae5d91e9c44377d6b19c9326e8e94f
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-08-04T15:51:06.000Z

    12954 Rewrite coretemp to use the ksensor framework
    12955 coretemp had the wrong granularity
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF