Project

General

Profile

Actions

Bug #12955

closed

coretemp had the wrong granularity

Added by Robert Mustacchi about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While working on #12954, I realized that past me had made a mistake that turned out not to matter too much. The ksensor framework has a notion of the granularity, being the units of the actual measurement and how to transform it into degrees, and the precision, being a +/- range that the sensor is accurate within. Hardware provides a register one can read which describes the actual precision which it calls the 'resolution'. In the original implementation in #11184 this was used as the 'granularity'. On almost all systems, this is one degree, so there was no impact from this and why when comparing the initial readings to the ipmi values on servers we didn't see any discrepancies. We should fix this while we're going through and doing #12954.


Related issues

Related to illumos gate - Feature #12954: Rewrite coretemp to use the ksensor frameworkClosedRobert Mustacchi

Actions
Actions #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 797
Actions #2

Updated by Robert Mustacchi about 1 year ago

  • Related to Feature #12954: Rewrite coretemp to use the ksensor framework added
Actions #3

Updated by Electric Monk 12 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 01c0c40b21ae5d91e9c44377d6b19c9326e8e94f

commit  01c0c40b21ae5d91e9c44377d6b19c9326e8e94f
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-08-04T15:51:06.000Z

    12954 Rewrite coretemp to use the ksensor framework
    12955 coretemp had the wrong granularity
    Reviewed by: Ryan Zezeski <ryan@zinascii.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF