Actions
Feature #12984
closed
devo_power misset in sensor drivers
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
Right now the sensor drivers, pchtemp(7D), coretemp(7D), amdnbtemp(7D), amdf17nbdf(7D) all inherited an incorrect devo_power setting of ddi_power due to various bad reasons. In reality these should be NULL to indicate that the entry point isn't supported by power(9E).
Updated by Garrett D'Amore about 1 year ago
Funny, I was just looking at that earlier this week. Thanks for taking this up.
There aren't many other consumers of ddi_power, and most of them are legacy SPARC drivers. These were the notable exceptions.
Updated by Robert Mustacchi about 1 year ago
I tested this by doing a basic spot testing of the amdf17nbdf driver and verified that it showed up in fmtopo with reasonable values.
Updated by Electric Monk about 1 year ago
- Status changed from New to Closed
- % Done changed from 90 to 100
git commit 64c2d2f3dba85d007642204d91961a84db9360cd
commit 64c2d2f3dba85d007642204d91961a84db9360cd
Author: Robert Mustacchi <rm@fingolfin.org>
Date: 2020-08-04T15:51:22.000Z
12984 devo_power misset in sensor drivers
Reviewed by: Paul Winder <paul@winder.uk.net>
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Randy Fishel <randyf@sibernet.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions