Project

General

Profile

Actions

Bug #12985

closed

fix wpi ddi_dma_nextcookie misuse

Added by Robert Mustacchi about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

A user in IRC hit an issue where they were booting and the system would panic with the message 'panic[cpu0]/thread=fffffe05434f7800: ddi_dma_nextcookie() called too many times on handle fffffe5460b8540'. In investigating with them, it appeared to be from the wpi driver. Looking at the wpi driver implementation, it was iterating over the end of the cookie list. The fix is simple, to use the new cookie routines.

The good news is that the user was able to test the prototype fix, was able to boot, and confirmed that wifi still worked out of that device.

Actions #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 813
Actions #2

Updated by Electric Monk 12 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 2590fb56d329661927485eb826679e9f44e9c3dc

commit  2590fb56d329661927485eb826679e9f44e9c3dc
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-07-29T15:19:37.000Z

    12985 fix wpi ddi_dma_nextcookie misuse
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Paul Winder <paul@winder.uk.net>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF