Project

General

Profile

Actions

Bug #13011

closed

tsalarm: '*' in boolean context, suggest '&&' instead

Added by Toomas Soome 12 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error on SPARC. It appear we should have & instead of *.

    ../../../sun4v/ontario/io/tsalarm.c: In function 'tsalarm_open':
    ../../../sun4v/ontario/io/tsalarm.c:547:20: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context]
       if (softc->flags * TSAL_IDENTED)
                        ^
    cc1: all warnings being treated as errors

Testing done: build/install/boot (on T4-1)

Actions #1

Updated by Electric Monk 12 months ago

  • Gerrit CR set to 826
Actions #2

Updated by Toomas Soome 11 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 11 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit ba12489a763ade223e478c59fdc4cb752fcba568

commit  ba12489a763ade223e478c59fdc4cb752fcba568
Author: Toomas Soome <tsoome@me.com>
Date:   2020-09-08T05:51:58.000Z

    13011 tsalarm: '*' in boolean context, suggest '&&' instead
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF