Project

General

Profile

Actions

Bug #13014

closed

ksensor tests are a bit environment dependent

Added by Robert Mustacchi 11 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There are two issues with the ksensor tests currently:

1. There is a missing package dependency between the os-tests and the ksensor package. Without this the tests themselves will not work. However, it's easy to miss this if you're doing development on this because you'll always have it installed.
2. The test runner, somewhat surprisingly has separate users that you need to indicate for the pre/post scripts and does not fallback on user. This meant that the calls to add_drv/rem_drv were failing because they were being run as an unprivileged user or were dependent on how they were invoked.

Both of these fixes are simple and should make this part of the test suite more reliable.

Actions #1

Updated by Electric Monk 11 months ago

  • Gerrit CR set to 830
Actions #2

Updated by Robert Mustacchi 10 months ago

This was tested by Toomas who hit it in his environment. We verfiied that all the ksensor tests successfully ran and passed.

Actions #3

Updated by Electric Monk 10 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b018085dfc5b5d4dc24cf2784f322e76bc3e91c0

commit  b018085dfc5b5d4dc24cf2784f322e76bc3e91c0
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-08-07T23:16:22.000Z

    13014 ksensor tests are a bit environment dependent
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF