Project

General

Profile

Actions

Bug #1303

closed

Grub should support large sector disks

Added by Hans Rosenfeld about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Urgent
Category:
zfs - Zettabyte File System
Start date:
2011-07-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The grub zfs code currently cannot open pools with ashift=12. This makes it impossible to boot from large sector disks.

Actions #2

Updated by Hans Rosenfeld about 10 years ago

updated webrev: http://cr.illumos.org/view/77bat2me/illumos-1303-webrev-2/

Changes since last webrev:
  • removed unused variable "trace"
  • fix support for mirrored pools (get the ashift property always from the vdev, not from the individual mirror disks)
  • some more cleanups for better readability
Actions #3

Updated by Hans Rosenfeld about 10 years ago

updated webrev: http://cr.illumos.org/view/3vs1alrf/illumos-1303-webrev-3/

Changes since last webrev:
  • removed VDEV_UBERBLOCK_SHIFT, reworked the related macros and code using them (requested by Eric Schrock)
Actions #4

Updated by Hans Rosenfeld about 10 years ago

updated webrev: http://cr.illumos.org/view/8grml9d1/illumos-1303-webrev-4/

Changes since last webrev, requested by George Wilson:
  • get the ashift directly in check_pool_label(), revert changes to vdev_get_params()
  • move the VDEV_UBERBLOCK macros to vdev_impl.h, changing them to resemble their counterparts in the kernel
Actions #5

Updated by Garrett D'Amore about 10 years ago

  • Status changed from New to Resolved

Thanks Hans. I've integrated your change.

garrett@thinkpad{9}> hg head
changeset: 13421:a4721c685d96
tag: tip
user: Hans Rosenfeld <>
date: Mon Aug 08 15:10:27 2011 -0700
description:
1303 Grub should support large sector disks
Reviewed by: Garrett D'Amore <>
Reviewed by: Albert Lee <>
Reviewed by: Eric Schrock <>
Reviewed by: George Wilson <>
Approved by: Garrett D'Amore <>

Actions

Also available in: Atom PDF