Project

General

Profile

Actions

Bug #13050

closed

bhyve kernel should be cstyle clean

Added by Patrick Mooney about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Once #13049 is addressed, it would be nice for the bhyve kernel code to be brought into compliance with cstyle so it can be removed from the exception lists.


Related issues

Related to illumos gate - Bug #13049: cstyle should tolerate freebsd headersClosedPatrick Mooney

Actions
Actions #1

Updated by Patrick Mooney about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Patrick Mooney about 1 year ago

  • Related to Bug #13049: cstyle should tolerate freebsd headers added
Actions #3

Updated by Electric Monk 11 months ago

  • Gerrit CR set to 1034
Actions #4

Updated by Patrick Mooney 10 months ago

Comprised of style changes, this can mostly be tested with wsdiff(1). Comparing it against a vanilla proto area, the only reported changes in the .text section are related to line offsets changing for asserts.

Actions #5

Updated by Patrick Mooney 10 months ago

In addition to wsdiff(1) reporting no changes of significance to the program text, I ran the build artifacts through the normal array of guest smoke tests on AMD and Intel machines. All of the guest instances booted an ran as expected.

Actions #6

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 2699b94cd4d1e9baf6bfcbe579328b398a9736e6

commit  2699b94cd4d1e9baf6bfcbe579328b398a9736e6
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-12-01T03:48:02.000Z

    13050 bhyve kernel should be cstyle clean
    Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF