Actions
Bug #13077
closed
bhyve kernel should be -Wformat clean
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
bhyve
Gerrit CR:
Description
When bhyve was ported to illumos, the printf-like warnings in the kernel were suppressed with -Wno-format. As we're doing other clean up there, it would be nice to remove that warning gag and fix any problems which arise.
Updated by Patrick Mooney about 1 year ago
- Status changed from New to In Progress
- % Done changed from 0 to 100
Updated by Patrick Mooney about 1 year ago
Given the nature of the change, testing was performed with wsdiff(1). It confirmed that the only changes to the bhyve text were line offsets moving about due to dead code removal. I also smoke-tested it to make sure that booting a guest was still fine, just as a precaution. (It passed that as well, as expected)
Updated by Electric Monk about 1 year ago
- Status changed from In Progress to Closed
git commit 9dc804b9db4598936de071708cbc40525f06eb5d
commit 9dc804b9db4598936de071708cbc40525f06eb5d
Author: Patrick Mooney <pmooney@pfmooney.com>
Date: 2020-09-09T19:50:22.000Z
13077 bhyve kernel should be -Wformat clean
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Approved by: Robert Mustacchi <rm@fingolfin.org>
Actions