Project

General

Profile

Bug #1308

oi-build allows multiple publish invocations

Added by Alasdair Lumsden over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
OI-Userland
Target version:
-
Start date:
2011-07-31
Due date:
% Done:

0%

Estimated time:
1.00 h
Difficulty:
Bite-size
Tags:
needs-triage

Description

In oi-build, in make-rules/ips.mk there is the following line:

$(MANIFEST_BASE)-%.mogrified: %.p5m $(BUILD_DIR) canonical-manifests

This line is responsible for creating the .mogrified file. This line currently depends on $(BUILD_DIR) - due to the way gmake works, if the timestamp changes on the $(BUILD_DIR), this target has to be remade.

Since a "gmake publish" touches files in $(BUILD_DIR), the date of the dir changes. This means you can re-run "pkg publish" over and over.

Removing $(BUILD_DIR) from the target list fixes this. By the time we get to create the .mogrified file, the $(BUILD_DIR) has been created already anyway.

History

#1

Updated by Alasdair Lumsden over 8 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF