Project

General

Profile

Actions
Copy link

Feature #13102

closed

ptools could be built with ctf

Added by Robert Mustacchi 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
882

Description

Currently the various ptools aren't built with ctf. If they had been, it'd be much easier to debug issues like #13101. Adding this would have made this substantially easier and is generally useful for the future.

Actions
Copy link
 #1

Updated by Electric Monk 11 months ago

  • Gerrit CR set to 882
Actions
Copy link
 #2

Updated by Robert Mustacchi 11 months ago

To test this I ran ctfdump on several of the ptools and confirmed that they now had CTF data.

Actions
Copy link
 #3

Updated by Electric Monk 11 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit fbfe962ed9b45c98bebaea25573c8b8f1630d482

commit  fbfe962ed9b45c98bebaea25573c8b8f1630d482
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-09-03T22:08:35.000Z

    13101 pargs dumps core when it can't read argv
    13102 ptools could be built with ctf
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF