Project

General

Profile

Actions

Bug #13103

closed

zfs: zvol_strategy() warn: unsigned 'off' is never less than zero

Added by Toomas Soome 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

warning from smatch:

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/fs/zfs/zvol.c:1229 zvol_strategy() warn: unsigned 'off' is never less than zero.

Also OpenZFS commit:

    zvol: unsigned off can not be less than zero
    Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
    Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
    Signed-off-by: Toomas Soome <tsoome@me.com>
    Closes #10867

Note that OpenZFS moved zvol code to OS specific files, this issue was carried to freebsd version, linux version has different implementation.

Testing done: build/install/boot.

Actions #1

Updated by Electric Monk 11 months ago

  • Gerrit CR set to 887
Actions #2

Updated by Toomas Soome 11 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 11 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 712669c9fa9278704a4ccefe1d96acaf29397d36

commit  712669c9fa9278704a4ccefe1d96acaf29397d36
Author: Toomas Soome <tsoome@me.com>
Date:   2020-09-08T04:43:30.000Z

    13103 zfs: zvol_strategy() warn: unsigned 'off' is never less than zero
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF