Project

General

Profile

Actions

Bug #13103

closed

zfs: zvol_strategy() warn: unsigned 'off' is never less than zero

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

warning from smatch:

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/fs/zfs/zvol.c:1229 zvol_strategy() warn: unsigned 'off' is never less than zero.

Also OpenZFS commit:

    zvol: unsigned off can not be less than zero
    Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
    Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
    Signed-off-by: Toomas Soome <tsoome@me.com>
    Closes #10867

Note that OpenZFS moved zvol code to OS specific files, this issue was carried to freebsd version, linux version has different implementation.

Testing done: build/install/boot.

Actions

Also available in: Atom PDF