Project

General

Profile

Actions

Bug #13105

closed

dnode_special_open() error: unchecked function return 'zrl_tryenter'

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

smatch error:

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/fs/zfs/dnode.c:1200 dnode_special_open() error: unchecked function return 'zrl_tryenter'

Because zrl_tryenter() can fail, it seems to me, we need to check for it.

See also: https://github.com/openzfs/zfs/pull/10876

Testing done: build/install/boot

Actions #1

Updated by Electric Monk about 1 year ago

  • Gerrit CR set to 889
Actions #2

Updated by Toomas Soome about 1 year ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d061fa1f216e55ded9f2c41eb77f6aa67479a1c5

commit  d061fa1f216e55ded9f2c41eb77f6aa67479a1c5
Author: Toomas Soome <tsoome@me.com>
Date:   2020-09-09T05:13:15.000Z

    13105 dnode_special_open() error: unchecked function return 'zrl_tryenter'
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF