clarify PPR transitions in bhyve vLAPIC
Between the complicated conditional logic for APICv vs. non-accelerated LAPIC emulation, and the TPR shadowing changes which were added to bhyve circa March 2020, it has become somewhat difficult to grasp how and when the value of the PPR in the virtual LAPIC is set. It would be valuable to make all of its value transitions clear, so that we know it is correct at all times. This will ensure that the guest can observe the correct value (via the LAPIC register) and we have the correct priority value to use for determining if an incoming interrupt should wake the guest.
Updated by Electric Monk about 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit c74a40a584c9d875009f725565896fd7e8ee38d6 Author: Patrick Mooney <email@example.com> Date: 2020-11-24T20:30:25.000Z 13007 bhyve vlapic should set TMR on intr accept 13106 clarify PPR transitions in bhyve vLAPIC 13132 VMX event injection can race in bhyve 13259 SVM event injection can race in bhyve Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Reviewed by: Toomas Soome <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>