Project

General

Profile

Actions

Bug #13110

closed

clean up compiler gags in bhyve kernel

Added by Patrick Mooney 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
bhyve
Gerrit CR:

Description

As part of porting bhyve to illumos, a number of compiler/smatch gags were added to its makefile in the interest of expediency. Now that bhyve is maturing in our tree, it would be nice to clean up as many of those as possible (or at least convenient).

Actions #1

Updated by Electric Monk 11 months ago

  • Gerrit CR set to 896
Actions #2

Updated by Patrick Mooney 11 months ago

While this change looks like a great candidate for wsdiff(1) testing, some combination of the modifications resulted in the compiler moving things about which made it too complicated to judge on disassembled diff alone.

In lieu of that, I've opted for the standard set of guest smoke tests:
- Linux
- Windows
- OmniOS
- OpenBSD
- FreeBSD

I tested on both AMD and Intel hardware, and they both performed as expected.

Actions #3

Updated by Electric Monk 11 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit db8733f5bbf6e1c41c482d70b2fe49470d1958de

commit  db8733f5bbf6e1c41c482d70b2fe49470d1958de
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-09-10T17:35:09.000Z

    13110 clean up compiler gags in bhyve kernel
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF