clean up compiler gags in bhyve kernel
As part of porting bhyve to illumos, a number of compiler/smatch gags were added to its makefile in the interest of expediency. Now that bhyve is maturing in our tree, it would be nice to clean up as many of those as possible (or at least convenient).
Updated by Patrick Mooney about 1 year ago
While this change looks like a great candidate for
wsdiff(1) testing, some combination of the modifications resulted in the compiler moving things about which made it too complicated to judge on disassembled diff alone.
In lieu of that, I've opted for the standard set of guest smoke tests:
I tested on both AMD and Intel hardware, and they both performed as expected.
Updated by Electric Monk about 1 year ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit db8733f5bbf6e1c41c482d70b2fe49470d1958de Author: Patrick Mooney <email@example.com> Date: 2020-09-10T17:35:09.000Z 13110 clean up compiler gags in bhyve kernel Reviewed by: Toomas Soome <firstname.lastname@example.org> Reviewed by: Richard Lowe <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>