Project

General

Profile

Actions

Bug #13115

closed

libc: variable 'readers' set but not used

Added by Toomas Soome 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error on SPARC:

    ../port/threads/rwlock.c: In function 'shared_rwlock_lock':
    ../port/threads/rwlock.c:508:11: error: variable 'readers' set but not used [-Werror=unused-but-set-variable]
      uint32_t readers;
               ^~~~~~~
    cc1: all warnings being treated as errors

Since this code is used with THREAD_DEBUG, we should use preprocessor conditionals here.

Testing done: build/install/boot

Actions #1

Updated by Electric Monk 11 months ago

  • Gerrit CR set to 898
Actions #2

Updated by Toomas Soome 11 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 11 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 5d2ed7273d684a5ddeb0970c96ef9cf3ddd4e044

commit  5d2ed7273d684a5ddeb0970c96ef9cf3ddd4e044
Author: Toomas Soome <tsoome@me.com>
Date:   2020-09-09T19:14:06.000Z

    13115 libc: variable 'readers' set but not used
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF