Project

General

Profile

Actions
Copy link

Bug #13117

closed

zfs: variable dereferenced before check

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
899

Description

smatch error:

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/fs/zfs/zvol.c:1164 zvol_dumpio() warn: variable dereferenced before check 'ze' (see line 1159)

We can use for loop there.

Testing done: build/install/boot

Actions
Copy link
 #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 899
Actions
Copy link
 #2

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 92db730eedd4fcf11958d5b89b6d63f99488d594

commit  92db730eedd4fcf11958d5b89b6d63f99488d594
Author: Toomas Soome <tsoome@me.com>
Date:   2020-09-11T21:13:30.000Z

    13117 zfs: variable dereferenced before check
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF